[UIK-2976] ellipsis improvements #2314
Open
+7,586
−4,391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emrush/intergalactic into UIK-2976/ellipsis-improvements
| }; | ||
| } | ||
| }, [hookOverride, ref.current]); | ||
| }, [hookOverride, ref]); |
Contributor
There was a problem hiding this comment.
I am not sure that ref will work either :) useRef returns stable reference to an object which will be the same across multiple renders
Contributor
Author
There was a problem hiding this comment.
yes, but this is a custom hook and a link to the in it can change
Contributor
There was a problem hiding this comment.
yeah, I see, but the result will be the same of you will have only [hookOverride] :)
…emrush/intergalactic into UIK-2976/ellipsis-improvements
## Changelog ### @semcore/base-components #### Changed - `Hint` now has slicker and more compact styles. <!--- Provide a general summary of your changes in the Title above --> ## Motivation and Context - updated Hint styles - removed Hint arrow - connected css vars to offset and padding (currently offset = padding, although I kept them separate to be able to change in the future) ## How has this been tested? Manually. ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue). - [ ] New feature (non-breaking change which adds functionality). - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected). - [x] Nice improve. ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I have updated the documentation accordingly. - [ ] I have added new tests on added of fixed functionality. --------- Co-authored-by: Valeryia Zimnitskaya <valeryia.zimnitskaya@semrush.com> Co-authored-by: ilia.brauer <ilia.brauer@semrush.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
@semcore/base-components
Changed
Hintnow has slicker and more compact styles.Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.mdfile with planned publish date.