Codex doc improvements#1166
Conversation
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: James Mitchell <jdm3@st-andrews.ac.uk>
Co-authored-by: James Mitchell <jdm3@st-andrews.ac.uk>
Co-authored-by: James Mitchell <jdm3@st-andrews.ac.uk>
james-d-mitchell
force-pushed
the
codex-doc-improvements
branch
from
32574b4 to
238f089
Compare
james-d-mitchell
force-pushed
the
codex-doc-improvements
branch
from
238f089 to
a11bc57
Compare
Joseph-Edwards
left a comment
Joseph-Edwards
left a comment
There was a problem hiding this comment.
On the whole, I'm very impressed by Codex's performance here. I have a few suggestions that I have outlined below, but most of these are personal preferences rather than Codex being wrong.
| <Returns>A free semigroup or monoid.</Returns> | ||
| <Description> | ||
| <C>FreeMonoidAndAssignGeneratorVars</C> is synonym with: | ||
| <C>FreeMonoidAndAssignGeneratorVars</C> is synonymous with: |
There was a problem hiding this comment.
I'm not sure if either synonymous or synonym are right here? Something like
A potential implementation of <C>FreeMonoidAndAssignGeneratorVars</C> is:
or something like that.
There was a problem hiding this comment.
Good point will update.
Co-authored-by: Joe Edwards <80713360+Joseph-Edwards@users.noreply.github.com>
Co-authored-by: Joe Edwards <80713360+Joseph-Edwards@users.noreply.github.com>
Thanks @Joseph-Edwards. Just to mention this was Codex with me reviewing every suggested change one file at a time, not just letting it rip :) |
3 participants
No description provided.