[php] add Semgrep grammar augmentation (was empty)#4
Draft
brandonspark wants to merge 1 commit intomainfrom
Draft
[php] add Semgrep grammar augmentation (was empty)#4brandonspark wants to merge 1 commit intomainfrom
brandonspark wants to merge 1 commit intomainfrom
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Auto-generated release from semgrep/ocaml-tree-sitter-semgrep#583, which builds out the previously-empty PHP Semgrep grammar augmentation.
The augmentation adds:
semgrep_ellipsis(...) in expression / statement / class-body / enum-body / formal-parameter / match-arm positionssemgrep_deep_ellipsis(<... expr ...>)semgrep_variadic_metavariable($...ARGS) in formal-parameter and argument positionssemgrep_metavar_ident($FOO) in class / interface / trait / enum / function / method names, named types, base/interface clauses, and attribute namesPHP variable-variable
$$Fkeeps its nativedynamic_variable_nameparse — see linked PR for details.Closes LANG-474, LANG-475.
Test plan
make build && make testpasses upstream (105 tests).🤖 Generated with Claude Code