feat: update interfaces for new scan-backend endpoints#435
Merged
chmccreery merged 8 commits intomainfrom Feb 17, 2026
Merged
Conversation
|
Backwards compatibility summary: |
chmccreery
force-pushed
the
cm/update-interfaces-async-config-gen
branch
from
e4fc265 to
2fa556d
Compare
…async-config-gen # Conflicts: # semgrep_output_v1.proto
amchiclet
approved these changes
Feb 17, 2026
chmccreery
commented
Feb 24, 2026
Comment on lines
+1679
to
+1694
| type create_scan_response_v2 | ||
| <doc text=" | ||
| Response from the backend to the CLI for POST /api/cli/v2/scans. | ||
| Keep in sync with the proto that is controlled inside semgrep-app API Framework. | ||
| "> | ||
| = { | ||
| body: create_scan_response_body; | ||
| } | ||
|
|
||
| type create_scan_response_body | ||
| <doc text=" | ||
| Internal format of the /api/cli/v2/scans response body field. | ||
| "> | ||
| = { | ||
| info: scan_info; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Tells CLI what the interface is including the body parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are separating /api/cli/scans into two endpoints to enable asynchronous config generation.
make setup && maketo update the generated code after editing a.atdfileFor example, the Semgrep backend need to still be able to consume data
generated by Semgrep 1.50.0.
See https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades
Note that the types related to the semgrep-core JSON output or the
semgrep-core RPC do not need to be backward compatible!
semgrep-proprietaryare approved and ready to merge once this PR is mergedCloses SMS-2145