Skip to content

Conversation

@dungeon-master-666
Copy link
Contributor

git pull --recurse-submodules does not initialize new submodules, it only updates existing ones. To fix it I added git submodule update --init --recursive.

@dungeon-master-666 dungeon-master-666 changed the title Git: fix initializing submodules on pull fix: initialize submodules on pull Dec 8, 2025
@fiftin fiftin requested a review from Copilot December 14, 2025 13:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes git submodule initialization during repository pulls in the CmdGitClient implementation. The issue was that git pull --recurse-submodules updates existing submodules but fails to initialize new submodules that were added to the repository. The fix splits the operation into two steps: first pulling the main repository, then explicitly running git submodule update --init --recursive to both initialize new submodules and update existing ones.

Key changes:

  • Split the pull operation into two separate git commands with proper error handling
  • Added explicit submodule initialization step after the main repository pull

@fiftin
Copy link
Collaborator

fiftin commented Dec 14, 2025

@codex review

@chatgpt-codex-connector
Copy link

To use Codex here, create a Codex account and connect to github.

@fiftin fiftin self-assigned this Dec 14, 2025
@fiftin
Copy link
Collaborator

fiftin commented Dec 14, 2025

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@fiftin fiftin merged commit 4e3945f into semaphoreui:develop Dec 14, 2025
21 checks passed
@fiftin
Copy link
Collaborator

fiftin commented Dec 14, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants