Skip to content

Conversation

@bburda
Copy link
Collaborator

@bburda bburda commented Jan 28, 2026

Pull Request

Summary

  • Fix Component fault listing to filter by hosted App FQNs instead of namespace path (too broad)
  • Fix Function fault listing to aggregate faults from host apps using their FQNs
  • Fix Area entity info to use actual namespace_path for fault filtering instead of empty string
  • Fix data endpoints to return complete type_info object with both 'schema' and 'default_value' fields
  • Refactor NativeTopicSampler to use future.wait_for() instead of custom spin loop

Issue

Link the related issue (required):


Type

  • Bug fix
  • New feature or tests
  • Breaking change
  • Documentation only

Testing

How was this tested / how should reviewers verify it?


Checklist

  • Breaking changes are clearly described (and announced in docs / changelog if needed)
  • Tests were added or updated if needed
  • Docs were updated if behavior or public API changed

…info response

- Fix Component fault listing to filter by hosted App FQNs instead of
  namespace path (too broad)
- Fix Function fault listing to aggregate faults from host apps using
  their FQNs
- Fix Area entity info to use actual namespace_path for fault filtering
  instead of empty string
- Fix data endpoints to return complete type_info object with both
  'schema' and 'default_value' fields
- Refactor NativeTopicSampler to use future.wait_for() instead of
  custom spin loop
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes issues with fault filtering for different entity types and completes the type_info response structure in data endpoints.

Changes:

  • Fixed fault filtering for Components to use hosted App FQNs instead of overly-broad namespace filtering
  • Fixed fault filtering for Functions to aggregate faults from host Apps using their FQNs
  • Fixed Area entity info to properly use namespace_path for fault filtering instead of empty string
  • Fixed data endpoints to return complete type_info object with both 'schema' and 'default_value' fields
  • Refactored NativeTopicSampler to use future.wait_for() instead of custom spin loop (cleaner implementation)

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
src/ros2_medkit_gateway/src/native_topic_sampler.cpp Refactored from custom spin loop to idiomatic future.wait_for() for message waiting
src/ros2_medkit_gateway/src/http/handlers/handler_context.cpp Fixed Area entity info to use actual namespace_path instead of empty string for fault filtering
src/ros2_medkit_gateway/src/http/handlers/fault_handlers.cpp Implemented FQN-based fault filtering for Components and Functions, replacing overly-broad namespace filtering
src/ros2_medkit_gateway/src/http/handlers/data_handlers.cpp Fixed type_info to return complete object with both 'schema' and 'default_value' fields

@bburda bburda merged commit 9310af2 into main Jan 28, 2026
10 checks passed
@bburda bburda deleted the fix/fault-filtering-and-missing-schema branch January 28, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Issues with fault filtering and missing type schema

3 participants