Switch to PNPM, Add extensions, update default template, remove vite template #290
Conversation
- Removed vite template - Added extensions - Updated docs - Updated default templates - Updated package versions - Added mantine UI
🦋 Changeset detectedLatest commit: ad761ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Move submodules to just be in the registry package - Exclude .next files
codebycarson
force-pushed
the
update/create-sei
branch
from
cebc810 to
979bf6c
Compare
codebycarson
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
==========================================
- Coverage 79.40% 79.29% -0.11%
==========================================
Files 82 82
Lines 1277 1280 +3
Branches 208 155 -53
==========================================
+ Hits 1014 1015 +1
- Misses 263 265 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR switches from Yarn to PNPM, removes the vite template, adds an extension system, updates default templates with Mantine UI, and modernizes the entire create-sei library.
Key changes:
- Replaced Yarn with PNPM as the package manager
- Removed Vite template, keeping only Next.js template with modern features
- Added extension system allowing modular template enhancements
- Updated default Next.js template with Mantine UI, Biome linting, and improved structure
Reviewed Changes
Copilot reviewed 77 out of 92 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Added PNPM workspace configuration |
| packages/*/package.json | Updated build scripts to use PNPM and dependencies |
| packages/create-sei/templates/vite-template/* | Removed entire Vite template |
| packages/create-sei/templates/next-template/* | Complete modernization with Mantine UI, new structure |
| packages/create-sei/src/main.ts | Added extension system and updated CLI interface |
| packages/create-sei/extensions/* | New extension system for template enhancements |
| .github/workflows/* | Updated CI/CD to use PNPM |
| docs/* | Updated documentation to reflect changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| * Creates a transport and app instance | ||
| * | ||
| * @returns {Promise<{transport: Transport, app: SeiApp}>} transport and app instances | ||
| * @returns transport and app instances |
There was a problem hiding this comment.
JSDoc return type comment should use proper format. Replace with @returns {Promise<{transport: Awaited<ReturnType<typeof Transport.create>>, app: SeiApp}>} transport and app instances
| * @returns transport and app instances | |
| * @returns {Promise<{transport: Awaited<ReturnType<typeof Transport.create>>, app: SeiApp}>} transport and app instances |
|
|
||
| enum FrontendScaffolding { | ||
| Vite = 'vite', | ||
| Next = 'next' | ||
| } | ||
|
|
||
| interface WizardOptions { | ||
| name?: string; |
There was a problem hiding this comment.
Missing JSDoc documentation for the WizardOptions interface properties. Consider adding documentation for name and extension parameters to help users understand their purpose and format requirements.
| // Example recipient address for demonstration | ||
| const exampleRecipient = '0x742d35cc6634C0532925a3b8D8C9C6c0C6c0C6c0'; |
There was a problem hiding this comment.
The example recipient address appears to be a placeholder with a repetitive pattern. Consider using a more realistic example address or clearly marking it as a placeholder to avoid confusion in production usage.
| // Example recipient address for demonstration | |
| const exampleRecipient = '0x742d35cc6634C0532925a3b8D8C9C6c0C6c0C6c0'; | |
| // Example recipient address for demonstration (replace with a real address in production) | |
| const exampleRecipient = '0x000000000000000000000000000000000000dead'; // placeholder address |
| - ESLint configuration | ||
| - Prettier formatting | ||
| - Biome formatting | ||
| - Mantine UI components |
There was a problem hiding this comment.
does the example app use mantine and tailwind?
There was a problem hiding this comment.
can there be one example app with mantine and one with tailwind? i think generally people use one or the other
There was a problem hiding this comment.
Yeah, we can improve this a bit more pretty easily now. We can do tailwind by default and mantine as an extension
Switch to PNPM & Add extensions and updated default templates
This PR updates the entire create-sei library to add extensions, update the default templates and upgrade all the library versions.
Changes