Skip to content

Conversation

@yzang2019
Copy link
Collaborator

Describe your changes and provide context

Remove SQLITE backend from ss store since we do not plan to support it and we have never used that before.

Testing performed to validate your change

@yzang2019 yzang2019 requested review from Kbhat1 and masih October 8, 2025 22:51
@yzang2019 yzang2019 requested a review from blindchaser October 8, 2025 22:52
@yzang2019 yzang2019 changed the title Remove SQLITE backend Remove SqlLite backend Oct 8, 2025
@yzang2019 yzang2019 changed the title Remove SqlLite backend Remove Sqlite backend Oct 8, 2025
@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.06%. Comparing base (c3ee918) to head (bd1e80c).
⚠️ Report is 3 commits behind head on main.

❌ Your project status has failed because the head coverage (40.06%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   40.00%   40.06%   +0.06%     
==========================================
  Files          59       59              
  Lines        7510     7533      +23     
==========================================
+ Hits         3004     3018      +14     
- Misses       4161     4168       +7     
- Partials      345      347       +2     
Files with missing lines Coverage Δ
ss/store.go 50.00% <ø> (+2.11%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yzang2019 yzang2019 merged commit 0ae35ba into main Oct 8, 2025
10 of 12 checks passed
@yzang2019 yzang2019 deleted the yzang/remove-sqlite branch October 8, 2025 23:35
Copy link
Collaborator

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late to the party but this LGTM, thank you for actioning this so quickly @yzang2019 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants