-
Notifications
You must be signed in to change notification settings - Fork 17
Add otel metrics for seidb #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
530da86
Add otel metrics for seidb
yzang2019 488613e
Add commit latency metrics
yzang2019 636e74a
Remove server
yzang2019 0b0a66e
Fix metrics
yzang2019 cc4d74f
Add metrics for seidb
yzang2019 8049bb1
Merge branch 'main' into yzang/add-metrics
yzang2019 534de71
fix go mod
yzang2019 5252396
Fix go version
yzang2019 fb465e5
Bump lint version
yzang2019 ce1e035
Bump lint version
yzang2019 d888816
Bump lint version
yzang2019 d261396
Bump lint version
yzang2019 b610ab8
Fix golint
yzang2019 06019a0
Fix golint
yzang2019 6fa9a20
Fix golint
yzang2019 e3f6e79
Fix golint
yzang2019 30fce5f
Fix golint
yzang2019 450451f
Fix golint
yzang2019 c547152
Fix golint
yzang2019 b20ee39
Fix golint
yzang2019 a41d132
Fix golint
yzang2019 c5a0004
Fix golint
yzang2019 ddc32cc
Fix golint
yzang2019 44bd4f8
Fix golint
yzang2019 c5de273
Fix golint
yzang2019 1395e55
Add latency metric with success
yzang2019 7ace1a5
Add comment
yzang2019 838e4f2
Merge latest
yzang2019 8cfe551
Update MemNode metrics from parent
yzang2019 925e75b
Add one more metric
yzang2019 9f4ce5c
Fix lint
yzang2019 0b567e7
Merge branch 'main' into yzang/add-metrics
yzang2019 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| package metrics | ||
|
|
||
| import ( | ||
| "go.opentelemetry.io/otel" | ||
| "go.opentelemetry.io/otel/metric" | ||
| ) | ||
|
|
||
| var ( | ||
| meter = otel.Meter("seidb") | ||
|
|
||
| SeiDBMetrics = struct { | ||
| RestartLatency metric.Float64Histogram | ||
| SnapshotCreationLatency metric.Float64Histogram | ||
| CommitLatency metric.Int64Histogram | ||
| ApplyChangesetLatency metric.Int64Histogram | ||
| NumOfKVPairs metric.Int64Counter | ||
| MemNodeTotalSize metric.Int64Gauge | ||
| NumOfMemNode metric.Int64Gauge | ||
| }{ | ||
| RestartLatency: must(meter.Float64Histogram( | ||
| "restart_latency", | ||
| metric.WithDescription("Time taken to restart the memiavl database"), | ||
| metric.WithUnit("s"), | ||
| )), | ||
| SnapshotCreationLatency: must(meter.Float64Histogram( | ||
| "snapshot_creation_latency", | ||
| metric.WithDescription("Time taken to create memiavl snapshot"), | ||
| metric.WithUnit("s"), | ||
| )), | ||
| CommitLatency: must(meter.Int64Histogram( | ||
| "commit_latency", | ||
| metric.WithDescription("Time taken to commit"), | ||
| metric.WithUnit("ms"), | ||
| )), | ||
| ApplyChangesetLatency: must(meter.Int64Histogram( | ||
| "apply_changeset_latency", | ||
| metric.WithDescription("Time taken to apply changesets"), | ||
| metric.WithUnit("ms"), | ||
| )), | ||
| NumOfKVPairs: must(meter.Int64Counter( | ||
| "num_of_kv_pairs", | ||
| metric.WithDescription("Num of kv pairs in apply changesets"), | ||
| metric.WithUnit("{count}"), | ||
| )), | ||
| MemNodeTotalSize: must(meter.Int64Gauge( | ||
| "mem_node_total_size", | ||
| metric.WithDescription("Total size of memnodes"), | ||
| metric.WithUnit("By"), | ||
| )), | ||
| NumOfMemNode: must(meter.Int64Gauge( | ||
| "mem_node_count", | ||
| metric.WithDescription("Total number of mem nodes"), | ||
| metric.WithUnit("{count}"), | ||
| )), | ||
| } | ||
| ) | ||
|
|
||
| // must panics if err is non-nil, otherwise returns v. | ||
| func must[V any](v V, err error) V { | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
| return v | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from chatGPT:
MemNodeSizeObs metric.Int64ObservableGaugetype is good for “now” value , same for MemNodeCount, for your considerationThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's what we want, please check the graph here:
