Optimize range proof instantiation #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dssei
reviewed
Dec 4, 2024
pkg/zkproofs/range.go
Outdated
| } | ||
|
|
||
| // Caches the verifiers created for each upper bound | ||
| type CachedRangeVerifier struct { |
Collaborator
There was a problem hiding this comment.
Curious if caching belongs to cryptography/zk layer? I thought we will do the actual caching in sei-chain layer, but here just add ability to plug the verifier e.g.
type RangeProofVerifier struct {
verifier *bulletproof.RangeVerifier
}
and then in method we just do
verified, err := r.verifier.Verify(proof.Proof, ciphertext.C, proofGenerators, upperBound, getTranscript())
Contributor
Author
There was a problem hiding this comment.
Implemented this way initially but this seems like a strictly better implementation (ie I can't see why the old method would be useful to keep around )
This is simar to what we do with the teg decryptor object
dssei
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Range proof Verification takes a long time.
30% of the time spent is initializing this RangeProofVerifier. In order to save some time, we should cache these verifiers and reuse them during verification.
Creates a struct that automatically caches verifiers for each upperbound, then reworks the Verify method to use this