Adding a test to ensure that tx commit order is properly tested #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tracers can expect that that `OnTxCommit` is called in proper transaction order so that it have the certitude that the current `OnTxCommit` is that correct one to happen relative to all other transaction. This is already the case, this test case only add a certain confidence that this assertion is going to be respected if any refactor happen in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracers can expect that that
OnTxCommitis called in proper transaction order so that it have the certitude that the currentOnTxCommitis that correct one to happen relative to all other transaction.This is already the case, this test case only add a certain confidence that this assertion is going to be respected if any refactor happen in the future.
Describe your changes and provide context
Testing performed to validate your change