Skip to content

Fix edge case for non atomic commit#3128

Open
yzang2019 wants to merge 8 commits intomainfrom
yzang/bug-fix-STO-436
Open

Fix edge case for non atomic commit#3128
yzang2019 wants to merge 8 commits intomainfrom
yzang/bug-fix-STO-436

Conversation

@yzang2019
Copy link
Copy Markdown
Contributor

@yzang2019 yzang2019 commented Mar 27, 2026

Describe your changes and provide context

This PR is intended to fix two issues:

  1. Make sure lattice hash is enabled if write mode is Split Write.
  2. If the node crashed during Commit after the cosmos store was committed but before the EVM/FlatKV one was, it will lead to an unrecovered mixed state with a wrong CommitInfo. The fix is to introduce some version reconciliation mechanism during initialization if the two DB version mismatch

Testing performed to validate your change

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 27, 2026, 7:59 PM

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 65.62500% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.75%. Comparing base (712bfd7) to head (fecd1c2).

Files with missing lines Patch % Lines
sei-db/state_db/sc/composite/store.go 54.16% 6 Missing and 5 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3128   +/-   ##
=======================================
  Coverage   58.74%   58.75%           
=======================================
  Files        2094     2094           
  Lines      173071   173097   +26     
=======================================
+ Hits       101671   101698   +27     
+ Misses      62340    62339    -1     
  Partials     9060     9060           
Flag Coverage Δ
sei-chain-pr 57.67% <65.62%> (?)
sei-db 70.41% <ø> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-db/config/sc_config.go 100.00% <100.00%> (ø)
sei-db/state_db/sc/composite/store.go 66.12% <54.16%> (-1.81%) ⬇️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

* main:
  Pass versioned changeset entries to wrappers + ApplyChangesetasync (#3120)
  Remove stale price snapshot creation from MidBlocker (#3117)
@yzang2019 yzang2019 enabled auto-merge March 28, 2026 11:51
@yzang2019 yzang2019 disabled auto-merge March 28, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant