[giga] abstract occ scheduler into interfaces #2610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codchen
force-pushed
the
tony/scheduler-interface
branch
from
cce0d85 to
6e47c9c
Compare
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2610 +/- ##
==========================================
+ Coverage 43.23% 48.35% +5.11%
==========================================
Files 1851 682 -1169
Lines 152771 59854 -92917
==========================================
- Hits 66055 28943 -37112
+ Misses 80835 28499 -52336
+ Partials 5881 2412 -3469
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+117
to
+119
| for storeKey, mvs := range mvs { | ||
| vs[storeKey] = mvs.VersionedIndexedStore(dt.absoluteIndex, dt.incarnation, abortCh) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
codchen
force-pushed
the
tony/scheduler-interface
branch
from
6e47c9c to
1c987dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
The existing OCC scheduler is somewhat coupled with Cosmos specific logics like
sdk.Contextand stores. This PR refactors the scheduler to be generic and not dependent on any Cosmos specific types, so that it can later be used for giga execution. Specifically this PR yields the following two interfaces for giga to implement and use:Testing performed to validate your change
refactor - existing tests should still hold