Skip to content

Conversation

@pompon0
Copy link
Contributor

@pompon0 pompon0 commented Oct 6, 2025

#2430 has changed semantics of SendRate/RecvRate=0 to block all traffic, which is backward incompatible. Reverting to the old semantics.

@pompon0 pompon0 requested review from masih, sei-will and udpatil October 6, 2025 10:57
Copy link
Collaborator

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor naming suggestion, otherwise LGTM

@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.16%. Comparing base (2ab1daf) to head (190d3ea).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sei-tendermint/internal/p2p/conn/connection.go 0.00% 12 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2440      +/-   ##
==========================================
- Coverage   27.17%   27.16%   -0.02%     
==========================================
  Files        1466     1466              
  Lines      144436   144446      +10     
==========================================
- Hits        39256    39232      -24     
- Misses     101823   101853      +30     
- Partials     3357     3361       +4     
Files with missing lines Coverage Δ
sei-tendermint/internal/p2p/conn/connection.go 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pompon0 pompon0 enabled auto-merge (squash) October 6, 2025 11:10
@pompon0 pompon0 merged commit 5755c30 into main Oct 6, 2025
101 of 105 checks passed
@pompon0 pompon0 deleted the gprusak-ratelimit-fix branch October 6, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants