-
Notifications
You must be signed in to change notification settings - Fork 856
Implement standalone transaction prioritizer #2320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aa0e4b8 to
eb764db
Compare
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (31.69%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2320 +/- ##
===========================================
- Coverage 46.72% 36.70% -10.03%
===========================================
Files 408 1166 +758
Lines 39574 104522 +64948
===========================================
+ Hits 18491 38362 +19871
- Misses 19796 62908 +43112
- Partials 1287 3252 +1965
🚀 New features to boost your workflow:
|
yzang2019
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
Extract the logic of transaction prioritisation from various Ante handlers for both EVM and cosmos transactions into a side effect free lightweight API exposed via ABCI interface.
Wile at it, fix minor typo and improve logging.
Refactor the preprocessor to optionally accept an already unpacked tx data.
3878ac7 to
2dad465
Compare
|
Marking this as draft until sei-cosmos mono repo move (and probably tendermint move) lands. |
# Conflicts: # go.mod # go.sum
Extract the logic of transaction prioritisation from various Ante handlers for both EVM and cosmos transactions into a side effect free lightweight API exposed via ABCI interface.
Relates to:
GetTxPriorityHintand mempool backpressure via priority drops sei-tendermint#301IntegrateRepo archived, and changes are ported to this PR.GetTxPriorityABCI interface sei-cosmos#598