-
Notifications
You must be signed in to change notification settings - Fork 862
ci: make Codecov uploads safe on forks (skip when token/secrets unavailable) #2293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: make Codecov uploads safe on forks (skip when token/secrets unavailable) #2293
Conversation
- Add comprehensive tests for event signatures - Add tests for event data encoding - Add tests for error handling in EmitEVMLog - Improve EmitEVMLog error handling for nil EVM and StateDB
…aking-evm-event-propagation
…rotocol/sei-chain into feat/staking-evm-event-propagation
* Make flushing receipt synchrnous * Add unit test and config for flush receipt sync * Fix config parsing * Fix config test
…2-payment-confirmation and conflict resolutions
…lement.yml-workflow Add Proof of Keeper settlement workflow
|
We truly appreciate your contribution and the time you’ve invested in this PR. |
|
This PR is being closed due to inactivity, but we want to acknowledge and thank you for the effort you’ve put in. |
Codecov uploads were failing on forked PRs and protected branches due to missing secrets and tokenless restrictions.
This change makes the Codecov step conditional so it only uploads when it’s safe and permitted, and skips gracefully on forked PRs (or when no token is available).
Why: GitHub never exposes repository secrets to workflows triggered from forks. Also, tokenless uploads aren’t allowed to protected branches. This was causing red CI.
What changed
CODECOV_TOKENonly when available.Validation
Matrix tested locally and via this branch:
CODECOV_TOKEN) → ✅ upload with tokenExpected log lines:
fail_ci_if_error: false)Security considerations
secrets.CODECOV_TOKENwhen present.Impact & tradeoffs
Alternatives considered
github-actions[bot]: not ideal; broad bypass weakens protections.Rollback plan
Revert this PR. No data/schema migrations; safe instant rollback.
Follow-ups (optional)
CODECOV_TOKENin repo/org secrets to ensure uploads on protected branches.Checklist
fail_ci_if_error: falseset