Open
Conversation
fredsa
force-pushed
the
refreshDebugState
branch
2 times, most recently
from
9c8f2a0 to
a880c5c
Compare
Skip unnecessary clearCurrentLine and setCurrentLine every tick when current PC marker does not need to be updated, which in turn avoid unnecessary EditorView.updateListener invocations every tick.
Remove clearCurrentLine and conditional check from refreshDebugState as the same functionality is duplicated in setCurrenLine.
fredsa
force-pushed
the
refreshDebugState
branch
from
a880c5c to
08072b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
every tick when there's nothing to update, avoiding
unnecessary EditorView.updateListener invocations
conditional check that is already in
setCurrenLine