Skip to content

Parital fix #212 stale gutter, anyTargetChanged->true#239

Open
fredsa wants to merge 2 commits intosehugg:masterfrom
fredsa:fix212
Open

Parital fix #212 stale gutter, anyTargetChanged->true#239
fredsa wants to merge 2 commits intosehugg:masterfrom
fredsa:fix212

Conversation

@fredsa
Copy link
Copy Markdown
Contributor

@fredsa fredsa commented Mar 11, 2026

Comment out implementation and have anyTargetChanged always return true.

Holding off on deleting the function
entirely, in case it needs to be brought
back in the immediate future.

@fredsa
Copy link
Copy Markdown
Contributor Author

fredsa commented Mar 11, 2026

I don't see any downside to always refreshing the views. Perhaps there's performance reason to do this on slower platforms I'm not aware of? Happy to hear your thoughts on what's needed.

@fredsa fredsa force-pushed the fix212 branch 4 times, most recently from ec7e721 to 75d7183 Compare March 24, 2026 01:32
@sehugg
Copy link
Copy Markdown
Owner

sehugg commented Mar 24, 2026

The intent was to keep the emulator from reloading while editing comments and whitespace. The gutter sometimes gets out of sync but only temporarily, are you seeing differently?

@fredsa
Copy link
Copy Markdown
Contributor Author

fredsa commented Mar 24, 2026

I've been focused on the editor experience, slightly ignoring the emulator, trying to fix issues when for examples moving existing lines of code, here's the clc has been separated from its gutter bytes:

image

I see now that resetting the emulator is a bit jumpy.

I'll see about updating the gutter but not resetting the emulator when the binary does not change.

@sehugg
Copy link
Copy Markdown
Owner

sehugg commented Mar 24, 2026

It's not only about resetting the emulator, when you have multiple object files like C or CA65 it takes a relatively long time to do a build, so you only run the full build if an object file changes. Unfortunately the debug info doesn't run until the full build completes. I never worried about it since you'll eventually sync up when you make a proper change.

fredsa added 2 commits March 25, 2026 17:52
Comment out implementation and have anyTargetChanged always return true.

Holding off on deleting the function
entirely, in case it needs to be brought
back in the immediate future.
@fredsa fredsa changed the title Fix #212 stale gutter, anyTargetChanged->true Parital fix #212 stale gutter, anyTargetChanged->true Mar 26, 2026
@fredsa
Copy link
Copy Markdown
Contributor Author

fredsa commented Mar 26, 2026

Ack. I hadn't realized the behavior for multi file C projects.

How's this updated PR?

For DASM, on source code only change:

  • Gutter is refreshed, but emulator is skipped, and console prints:

unchanged, skipping loadROM

For multi-file C, behavior is still the same:

  • Stale gutter can happen with certain edits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants