This repository was archived by the owner on Dec 11, 2019. It is now read-only.
Identifying source of identify/page request #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@hankim813 hey, this is Jakub from SatisMeter. This change identifies calls coming to us from Segment, so that we can improve first-time experience for our common customers. How can we get it merged and released? Thanks! |
Contributor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm Alberto from SatisMeter.
We need to be able to identify where the request for
identifyandpagecame from, in order to know if it came fromanalytics.jsor other source.Also I switched from PhantomJs to Chrome in
karma.conf. PhantomJs lacks support for ES6 Promises and it's development has been suspended until further notice (see ariya/phantomjs#15344).