Continue instead of crashing when objects are missing #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen with submodules. Closes seeyebe#3 Before: ``` Error: Failed to collect commits from repository Caused by: 0: Object find error: An object with id fdb30228b1dc649ab1c2086d146ef9dd0ab584e6 could not be found 1: An object with id fdb30228b1dc649ab1c2086d146ef9dd0ab584e6 could not be found ``` After: ``` ⠋ Collecting commits... Warning: Object find error: An object with id fdb30228b1dc649ab1c2086d146ef9dd0ab584e6 could not be found ⠦ Collecting commits... Warning: Object find error: An object with id fc412cbdf765175ea9f3380db6b9e1b1603a68a7 could not be found ⠤ Collecting commits... Warning: Object find error: An object with id b699a7e01c253ffb7818b02d62bce24190ec1019 could not be found ⠁ Collecting commits... Warning: Object find error: An object with id b699a7e01c253ffb7818b02d62bce24190ec1019 could not be found Commits collected ``` Not the prettiest, but better than a crash!
Owner
|
I like the idea of warning instead of crashing. I was thinking we might be able to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen with submodules.
Closes #3
Before:
After:
Not the prettiest, but better than a crash!