First‐class support for the new Mail extensions on macOS 13+#287
Open
theZ3r0CooL wants to merge 1 commit intoseemoo-lab:mainfrom
Open
First‐class support for the new Mail extensions on macOS 13+#287theZ3r0CooL wants to merge 1 commit intoseemoo-lab:mainfrom
theZ3r0CooL wants to merge 1 commit intoseemoo-lab:mainfrom
Conversation
Falls back to the old `.mailbundle` plugin on earlier releases
• `MailPluginManager.swift`
– Added `supportsMailExtension` check (#available(macOS 13, *)).
– Updated `isMailPluginInstalled` to immediately returns true on 13+, otherwise does the old bundle-UUID check.
– `installMailPlugin()` is a no-op on 13+ (just opens Mail.app to let the user enable the extension) & still copies the bundle on older macOS.
– `uninstallMailPlugin()` & `pluginDownload()` similarly skip bundle actions on 13+.
• `OpenHaystackSettingsView.swift`
– The toggle label now switches based on OS version: “Use Apple Mail Plugin (≤12)” vs “Enable Mail Extension (≥13)”.
• `OpenHaystackMainView.swift`
– The toolbar “Reload” button reads “Reload Extension” on 13+ (stays “Reload” on older macOS).
– The popover text dynamically refers to the “mail extension” vs “mail plug-in” based on runtime availability.
• `OpenHaystackTests.swift`
– `testPluginInstallation()` now skips itself on macOS 13+ with `try XCTSkip(...)` & only runs the bundle-copy assertions on older OS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Falls back to the old
.mailbundleplugin on earlier releases