-
Notifications
You must be signed in to change notification settings - Fork 5
Fix ground truth for inheritance/MRO benchmarks (Liskov substitution) #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jaltmayerpizzorno
wants to merge
20
commits into
secure-software-engineering:main
Choose a base branch
from
plasma-umass:fix-inheritance-ground-truth
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10
−3
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
934de26
Merge branch '202510-righttyper-support'
jaltmayerpizzorno f35ece8
Merge branch '202510-corrections'
jaltmayerpizzorno 0ce1258
Merge branch '202510-corrections'
jaltmayerpizzorno 35fa775
- fixed coordinates;
jaltmayerpizzorno e6da004
- fixed types not being parametrized;
jaltmayerpizzorno 81f2ce8
- fixed missing "function" context;
jaltmayerpizzorno 09bdce5
- fixed coordinate;
jaltmayerpizzorno 03c842f
- fixed incorrect function context;
jaltmayerpizzorno 4959d1c
- fixed type not being parametrized;
jaltmayerpizzorno a40d4db
- deleted entry from ground truth, as it describes a call, not a vari…
jaltmayerpizzorno 378745a
- fixed invalid dictionary keys in subscript expressions;
jaltmayerpizzorno 3991208
- fixed type, which wasn't parametrized;
jaltmayerpizzorno e010ba9
- fixed index out of range error due to <value1> interfering with enu…
jaltmayerpizzorno 1c03981
Merge branch 'secure-software-engineering:main' into main
jaltmayerpizzorno 348f225
Merge branch 'secure-software-engineering:main' into 202510-correctio…
jaltmayerpizzorno f167d80
Merge branch '202510-corrections-2'
jaltmayerpizzorno 00311c4
- deleted entry from ground truth, as it describes a call, not a vari…
jaltmayerpizzorno bdd2c78
Merge branch '202510-corrections-2'
jaltmayerpizzorno 10ab41a
Merge branch 'secure-software-engineering:main' into main
jaltmayerpizzorno da3f9ed
Fix ground truth for inheritance/MRO benchmarks (Liskov substitution)
jaltmayerpizzorno File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ | |
| "col_offset": 9, | ||
| "function": "MyClass.func", | ||
| "type": [ | ||
| "int", | ||
| "str" | ||
| ] | ||
| }, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ | |
| "col_offset": 9, | ||
| "function": "A.func", | ||
| "type": [ | ||
| "int", | ||
| "str" | ||
| ] | ||
| }, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,7 +24,8 @@ | |
| "col_offset": 9, | ||
| "function": "B.func", | ||
| "type": [ | ||
| "int" | ||
| "int", | ||
| "str" | ||
| ] | ||
| }, | ||
| { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,6 +14,7 @@ | |
| "col_offset": 9, | ||
| "function": "B.func", | ||
| "type": [ | ||
| "int", | ||
| "str" | ||
| ] | ||
| }, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In
two_parents_method_defined,B.func's ground-truth return types includefloat, butB.funconly returns anintand the only override in this benchmark isC.funcreturningstr(so the LSP-widened type should beint | str). Includingfloatappears to over-approximate the actual method/override set forBin this benchmark and makes the ground truth less precise; consider removingfloatfromB.func'stypelist.