Skip to content

#5855 Added a way to check triangles for all lods#5873

Merged
akleshchev merged 1 commit into
developfrom
andreyk/viewer_5855
May 28, 2026
Merged

#5855 Added a way to check triangles for all lods#5873
akleshchev merged 1 commit into
developfrom
andreyk/viewer_5855

Conversation

@akleshchev
Copy link
Copy Markdown
Contributor

@akleshchev akleshchev commented May 28, 2026

  • Added lod level fields to the 'more info' (adavanced) floater.
  • Improved update mechanism to avoid excessive refreshes and to avoid setting drawables from draw
  • Fixed advanced floater, it become too tight since 26.2 changes (after font became bigger)
  • Small cleanup

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds per-LOD triangle counts to the Object Weights ("Advanced") floater and reworks the refresh flow so that selection/mesh-related updates happen via an idle callback driven by LLSelectMgr::mUpdateSignal and the active mesh LOD request counter, instead of being computed and applied inside draw(). Also generalizes the volume LOD triangle-count helper and removes an unused signal connection member from LLSelectMgr.

Changes:

  • Add LOD INFO section (High/Medium/Low/Lowest triangles) to floater_object_weights.xml and corresponding member text boxes / loading-indicator toggle in LLFloaterObjectWeights.
  • Replace per-draw refresh with onIdleRefresh + dirty flags driven by mUpdateSignal and LLMeshRepoThread::sActiveLODRequests, deferring getSelectedObjectRenderCost() out of the coroutine callback.
  • Generalize LLVOVolume::getHighLODTriangleCount into getLODTriangleCount(S32 lod) and add LLViewerObject::recursiveGetLODTriangleCount(...).

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
indra/newview/skins/default/xui/en/floater_object_weights.xml Widens floater, adds LOD-info section with 4 LOD triangle counts and loading indicators.
indra/newview/llvovolume.h / llvovolume.cpp Adds getLODTriangleCount(S32 lod); getHighLODTriangleCount() now delegates to it.
indra/newview/llviewerobject.h / llviewerobject.cpp Adds virtual getLODTriangleCount and recursiveGetLODTriangleCount helper.
indra/newview/llselectmgr.h / llselectmgr.cpp Removes unused mSlectionLodModChangedConnection member and its disconnect.
indra/newview/llfloaterobjectweights.h / .cpp Adds idle-driven refresh, dirty flags, selection signal connection, LOD UI wiring, and moves render-cost computation out of the coroutine callback.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread indra/newview/llfloaterobjectweights.cpp
Comment thread indra/newview/llfloaterobjectweights.h Outdated
Comment thread indra/newview/llfloaterobjectweights.cpp Outdated
Comment thread indra/newview/llfloaterobjectweights.cpp Outdated
Comment thread indra/newview/llfloaterobjectweights.cpp Outdated
@akleshchev akleshchev force-pushed the andreyk/viewer_5855 branch from c9d0544 to 5ad7588 Compare May 28, 2026 00:40
@akleshchev akleshchev force-pushed the andreyk/viewer_5855 branch from 5ad7588 to 68c9e82 Compare May 28, 2026 01:18
@akleshchev akleshchev linked an issue May 28, 2026 that may be closed by this pull request
@akleshchev akleshchev merged commit 0be2780 into develop May 28, 2026
15 checks passed
@akleshchev akleshchev deleted the andreyk/viewer_5855 branch May 28, 2026 15:16
@github-actions github-actions Bot locked and limited conversation to collaborators May 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

View Previously Used LOD Triangle Settings for Uploaded Meshes

4 participants