#5855 Added a way to check triangles for all lods#5873
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds per-LOD triangle counts to the Object Weights ("Advanced") floater and reworks the refresh flow so that selection/mesh-related updates happen via an idle callback driven by LLSelectMgr::mUpdateSignal and the active mesh LOD request counter, instead of being computed and applied inside draw(). Also generalizes the volume LOD triangle-count helper and removes an unused signal connection member from LLSelectMgr.
Changes:
- Add
LOD INFOsection (High/Medium/Low/Lowest triangles) tofloater_object_weights.xmland corresponding member text boxes / loading-indicator toggle inLLFloaterObjectWeights. - Replace per-draw refresh with
onIdleRefresh+ dirty flags driven bymUpdateSignalandLLMeshRepoThread::sActiveLODRequests, deferringgetSelectedObjectRenderCost()out of the coroutine callback. - Generalize
LLVOVolume::getHighLODTriangleCountintogetLODTriangleCount(S32 lod)and addLLViewerObject::recursiveGetLODTriangleCount(...).
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| indra/newview/skins/default/xui/en/floater_object_weights.xml | Widens floater, adds LOD-info section with 4 LOD triangle counts and loading indicators. |
| indra/newview/llvovolume.h / llvovolume.cpp | Adds getLODTriangleCount(S32 lod); getHighLODTriangleCount() now delegates to it. |
| indra/newview/llviewerobject.h / llviewerobject.cpp | Adds virtual getLODTriangleCount and recursiveGetLODTriangleCount helper. |
| indra/newview/llselectmgr.h / llselectmgr.cpp | Removes unused mSlectionLodModChangedConnection member and its disconnect. |
| indra/newview/llfloaterobjectweights.h / .cpp | Adds idle-driven refresh, dirty flags, selection signal connection, LOD UI wiring, and moves render-cost computation out of the coroutine callback. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c9d0544 to
5ad7588
Compare
5ad7588 to
68c9e82
Compare
marchcat
approved these changes
May 28, 2026
maxim-productengine
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.