Refactor remaining SDL2 references to remove version specificity and improve clarity #5285
+148
−148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes "SDL2" from the remaining variable names in order to improve clarity of the function. This has no functionality change, this is code clean up only.
I went with just "SDL" over naming them "SDL3", as "SDL" refers to just Simple DirectMedia Layer, rather than a specific version. Should SDL4 come out and the viewer upgrade to it, this makes less stuff to rename in the future. This also aligns with various other variable names.
Related Issues
Issue Link: N/A
Checklist
Please ensure the following before requesting review:
Additional Notes
This DOES NOT change
media_plugins/cef/media_plugin_cef.cpp: mCEFLib->nativeKeyboardEventSDL2(key_event, native_virtual_key, native_modifiers, keypad);, which is the last remaining entry for this. This requires modifying the CEF lib which I am uncomfortable with doing.