Skip to content

Conversation

@FelixWolf
Copy link
Contributor

@FelixWolf FelixWolf commented Jan 15, 2026

Description

This removes "SDL2" from the remaining variable names in order to improve clarity of the function. This has no functionality change, this is code clean up only.

I went with just "SDL" over naming them "SDL3", as "SDL" refers to just Simple DirectMedia Layer, rather than a specific version. Should SDL4 come out and the viewer upgrade to it, this makes less stuff to rename in the future. This also aligns with various other variable names.

Related Issues

  • Please link to a relevant GitHub issue for additional context.
    • Bug Fix: Link to an issue that includes reproduction steps and testing guidance.
    • Feature/Enhancement: Link to an issue with a write-up, rationale, and requirements.

Issue Link: N/A


Checklist

Please ensure the following before requesting review:

  • I have provided a clear title and detailed description for this pull request.
  • If useful, I have included media such as screenshots and video to show off my changes.
  • The PR is linked to a relevant issue with sufficient context.
  • I have tested the changes locally and verified they work as intended.
  • All new and existing tests pass.
  • Code follows the project's style guidelines.
  • Documentation has been updated if needed.
  • Any dependent changes have been merged and published in downstream modules
  • I have reviewed the contributing guidelines.

Additional Notes

This DOES NOT change media_plugins/cef/media_plugin_cef.cpp: mCEFLib->nativeKeyboardEventSDL2(key_event, native_virtual_key, native_modifiers, keypad);, which is the last remaining entry for this. This requires modifying the CEF lib which I am uncomfortable with doing.

@FelixWolf
Copy link
Contributor Author

FelixWolf commented Jan 15, 2026

I accidentally had the base branch to merge into set to develop instead of develop-linux, as such github-actions added all the tags it possibly could, even after I changed the base branch to develop-linux.
90% of them can be removed, this only affects c/cpp and llwindow.

Copy link
Collaborator

@Geenz Geenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Geenz Geenz merged commit d0db6a4 into secondlife:develop-linux Jan 20, 2026
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants