Fix SSH host key verification in deploy provisioning#63
Open
Fix SSH host key verification in deploy provisioning#63
Conversation
jkaczman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the deploy tool would SSH into a server without showing the server’s host key to the user or asking them to verify it. This fixes that by fetching the server’s SSH host key fingerprint first and requiring the verified fingerprint to match before authenticated SSH work can proceed. If the server later presents a different key than the one the user verified, deployment stops with an error instead of continuing with an unverified server.
The server provisioning screen walks users through fetching and confirming the fingerprint.