Remove unused phpunit/php-file-iterator dependency#1136
Closed
jwpage wants to merge 1 commit intosebastianbergmann:mainfrom
Closed
Remove unused phpunit/php-file-iterator dependency#1136jwpage wants to merge 1 commit intosebastianbergmann:mainfrom
jwpage wants to merge 1 commit intosebastianbergmann:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1136 +/- ##
=========================================
Coverage 88.21% 88.21%
Complexity 1398 1398
=========================================
Files 105 105
Lines 4718 4718
=========================================
Hits 4162 4162
Misses 556 556 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Good catch, thank you. I cherry-picked this into |
Contributor
|
might be worth setting up https://github.com/shipmonk-rnd/composer-dependency-analyser |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR drops the
phpunit/php-file-iteratordependency from composer.json, since 11.0 removed theFilter::includeDirectoryandFilter::excludeDirectorymethods which relied on it.