support ghc9103+ghc9124, fix nix build#209
Open
sectore wants to merge 3 commits intoseanhess:mainfrom
Open
Conversation
Owner
|
Thanks! |
Owner
|
You know this is marked work in progress? I didn't know that feature existed, seems useful. LMK when it's ready :) |
Contributor
Author
|
Could you check #208 and let me know about ghc version Hyperbole should support, pls? Can we remove BTW: What's the ghc version you run locally? As you said you don't use Nix ... |
working / tested: - [x] `nix flake check` - [x] `nix build .#ghc984-hyperbole-demo` - [x] `nix build .#ghc9103-hyperbole-demo` Note: `ghc967` has been deactivated since it could not run tests (`skeletest` requires GHC `>=9.8`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support (new)
ghc9103ghc9124It follows
ghcversions available in Nix viahaskell.packages:Not supported (Nix only)
ghc967as it could not run tests (skeletestrequires GHC>=9.8)Question: Can we remove 9.6.x entirely? It has been already deactivated in haskell.yaml workflow.
Fixed
nix flake checknix build .#ghc984-hyperbole-demonix build .#ghc9103-hyperbole-demoCloses #208