Fix internal links in HTML export with base href #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add <base href="/eli/"> to HTML documents to resolve relative links correctly - Update INTERNAL_LINKS_BASE_URL to include /eli/ prefix (https://selex.se/eli) - Internal links now use /sfs/ paths which resolve to /eli/sfs/ via base href - Add serve_html.py script for local testing of HTML site - Update documentation with instructions for local testing This ensures internal SFS links work correctly both in production and when testing locally with the HTTP server. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes internal SFS links in HTML export to work correctly both in production and local testing environments.
Changes
<base href="/eli/">to HTML documents: Enables relative link resolution for local testingINTERNAL_LINKS_BASE_URL: Now includes/eli/prefix (default:https://selex.se/eli)/sfs/paths which resolve to/eli/sfs/via base hrefscripts/serve_html.pyfor serving HTML site locallyWhy
Previously, internal links in HTML documents used
/sfs/paths which didn't match the actual/eli/sfs/directory structure, causing 404 errors when testing locally.Test plan
python scripts/serve_html.py/eli/sfs/...🤖 Generated with Claude Code