Remove SingleTableProgrammableConstraint class#2887
Merged
frances-h merged 2 commits intoMay 21, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2887 +/- ##
==========================================
- Coverage 98.03% 98.02% -0.01%
==========================================
Files 73 73
Lines 8396 8370 -26
==========================================
- Hits 8231 8205 -26
Misses 165 165
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
frances-h
force-pushed
the
issue-2882-remove-SingleTableProgrammableConstraint
branch
from
e365974 to
fba66a9
Compare
R-Palazzo
approved these changes
May 20, 2026
| super().__init__() | ||
| self.programmable_constraint = programmable_constraint | ||
| self.table_name = getattr(self.programmable_constraint, 'table_name', None) | ||
| self.table_name = getattr(programmable_constraint, 'table_name', None) |
Contributor
Author
There was a problem hiding this comment.
I tried to revert this change, but there's a check in multi-table that forces single-table constraints to have the table_name attribute set.
I'll revert this change here back to what it was, I just wanted to comment on why I tried to change it in the first place.
amontanez24
approved these changes
May 20, 2026
frances-h
force-pushed
the
issue-2882-remove-SingleTableProgrammableConstraint
branch
from
10733d7 to
e86ab7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #2882