Add extremity data points of the Pareto curve for the Quality–Speed Tradeoff plot#557
Open
Add extremity data points of the Pareto curve for the Quality–Speed Tradeoff plot#557
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #557 +/- ##
==========================================
+ Coverage 81.41% 82.02% +0.61%
==========================================
Files 33 33
Lines 2819 2843 +24
==========================================
+ Hits 2295 2332 +37
+ Misses 524 511 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fealho
approved these changes
Feb 24, 2026
|
|
||
|
|
||
| def post_benchmark_launch_message(date_str, compute_service='AWS', modality='single_table'): | ||
| """Post a message to the SDV Alerts Slack channel when the benchmark is launched.""" |
Member
There was a problem hiding this comment.
Update docstring, not SDV Alerts Slack anymore
|
|
||
|
|
||
| def post_benchmark_uploaded_message(folder_name, commit_url=None, modality='single_table'): | ||
| """Post benchmark uploaded message to sdv-alerts slack channel.""" |
Member
There was a problem hiding this comment.
Update docstring, not SDV Alerts Slack anymore
| """Add extremity points to the Pareto curve for better visualization.""" | ||
| pareto = df_to_plot.loc[df_to_plot['Pareto']].sort_values('Aggregated_Time') | ||
| if len(pareto) < 2: | ||
| return df_to_plot # Not enough points to define a curve |
Member
There was a problem hiding this comment.
Since you removed the reset_index from line 213 you need to add it back here as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #555
Resolve #556
CU-86b8m4mbk
CU-86b8m3jz2
Here is the upload message sent to the sdgym channel