Skip to content

[PWGLF] Please consider the following formatting changes to #14240 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alibuild wants to merge 1 commit into from
Closed

[PWGLF] Please consider the following formatting changes to #14240 #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PWGLF/Utils/svPoolCreator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#include "DCAFitter/DCAFitterN.h"
#include "Framework/AnalysisDataModel.h"

using std::array;

Check failure on line 25 in PWGLF/Utils/svPoolCreator.h

View workflow job for this annotation

GitHub Actions / O2 linter

[import-std-name] 

Do not import names from the std namespace in headers.
using CollBracket = o2::math_utils::Bracket<int>;

constexpr uint64_t bOffsetMax = 241; // track compatibility can never go beyond 6 mus (ITS)
Expand Down Expand Up @@ -55,7 +55,7 @@

void clearPools()
{
for (auto& pool : trackCandPool) {

Check failure on line 58 in PWGLF/Utils/svPoolCreator.h

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
pool.clear();
}
tmap.clear();
Expand Down Expand Up @@ -150,7 +150,7 @@
float trackTimeRes{0.};
if (trackCand.isPVContributor()) {
trackTime = trackCand.template collision_as<C>().collisionTime(); // if PV contributor, we assume the time to be the one of the collision
trackTimeRes = o2::constants::lhc::LHCBunchSpacingNS; // 1 BC
trackTimeRes = o2::constants::lhc::LHCBunchSpacingNS; // 1 BC
} else {
trackTime = trackCand.trackTime();
trackTimeRes = trackCand.trackTimeRes();
Expand Down Expand Up @@ -199,12 +199,12 @@
gsl::span<std::vector<TrackCand>> track1Pool{trackCandPool.data() + 2, 2};
std::array<std::vector<int>, 2> mVtxTrack0{}; // 1st pos. and neg. track of the kink pool for each vertex

for (int i = 0; i < 2; i++) {

Check failure on line 202 in PWGLF/Utils/svPoolCreator.h

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
mVtxTrack0[i].clear();
mVtxTrack0[i].resize(collisions.size(), -1);
}

for (int pn = 0; pn < 2; pn++) {

Check failure on line 207 in PWGLF/Utils/svPoolCreator.h

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
auto& vtxFirstT = mVtxTrack0[pn];
const auto& signTrack0Pool = track0Pool[pn];
for (unsigned i = 0; i < signTrack0Pool.size(); i++) {
Expand Down
Loading