tests: replace SimpleStrategy with NetworkTopologyStrategy#883
Merged
Conversation
ScyllaDB has dropped support for SimpleStrategy. Update all CQL statements, test fixtures, examples, benchmarks, and management utilities to use NetworkTopologyStrategy instead. The SimpleStrategy class definition in cassandra/metadata.py is preserved for backward compatibility with Cassandra clusters.
roydahan
force-pushed
the
more-simple-strategy
branch
from
47537c4 to
c56fbf8
Compare
8 tasks
dkropachev
approved these changes
May 11, 2026
Collaborator
dkropachev
left a comment
dkropachev
left a comment
There was a problem hiding this comment.
Looks good, failure has nothing todo with this PR
Collaborator
|
@roydahan just FYI I didn't touch those tests in my PR because they are not executed in out CI e.g. tests in tests/integration/long |
Collaborator
I do remember we discussed em |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScyllaDB has dropped support for SimpleStrategy. Update all tests to use NetworkTopologyStrategy instead. Hosts in token replica map tests now include datacenter and rack attributes as required by NTS.
Pre-review checklist
./docs/source/.Fixes:annotations to PR description.