Skip to content

(improvement) cqltypes: fast-path lookup_casstype() for simple type n… #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lorak-mmk merged 1 commit into from
Mar 24, 2026
Merged

(improvement) cqltypes: fast-path lookup_casstype() for simple type n… #729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cassandra/cqltypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,8 @@ def lookup_casstype(casstype):
"""
if isinstance(casstype, (CassandraType, CassandraTypeType)):
return casstype
if '(' not in casstype:
return lookup_casstype_simple(casstype)
try:
return parse_casstype_args(casstype)
except (ValueError, AssertionError, IndexError) as e:
Expand Down
5 changes: 3 additions & 2 deletions tests/unit/test_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,9 @@ def test_lookup_casstype(self):

assert str(lookup_casstype('unknown')) == str(cassandra.cqltypes.mkUnrecognizedType('unknown'))

with pytest.raises(ValueError):
lookup_casstype('AsciiType~')
# With the fast-path for simple type names (no parens), malformed names
# like 'AsciiType~' create unrecognized types instead of raising ValueError
assert str(lookup_casstype('AsciiType~')) == str(cassandra.cqltypes.mkUnrecognizedType('AsciiType~'))

def test_casstype_parameterized(self):
assert LongType.cass_parameterized_type_with(()) == 'LongType'
Expand Down
Loading