Use protocol-level BatchStatement in cqlengine BatchQuery #676
+60
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, BatchQuery.execute() serialized batches to CQL strings (BEGIN BATCH ... APPLY BATCH). This changes it to use the protocol-level BatchStatement from cassandra/query.py instead. Changes: - Add timestamp attribute to BatchStatement for batch-level timestamps - Update Session._create_response_future() to use BatchStatement.timestamp - Add BatchStatement handling to cqlengine execute() - Refactor BatchQuery.execute() to build and execute a BatchStatement Benefits: - Better performance (no string serialization overhead) - Proper type detection (isinstance checks for BatchStatement now work) - Batch-level timestamps preserved through protocol Fixes #208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BatchQuery.execute()from CQL string serialization to protocol-levelBatchStatementtimestampattribute toBatchStatementfor batch-level timestampsisinstance(query, BatchStatement)check at cluster.py:5332)Changes
timestampattribute toBatchStatementBatchStatement.timestampwhen availableBatchStatementinexecute()BatchQuery.execute()to useBatchStatementBenefits
isinstancechecks forBatchStatementnow work)Fixes #208