Include original error in ConnectionShutdown messages #658
+106
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a connection is closed or becomes defunct, include the last_error in the ConnectionShutdown exception message. This helps investigate issues where the original cause (e.g., "Bad file descriptor") was previously lost when subsequent operations tried to use the connection. Refs #614
sylwiaszunejko
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a connection is closed or becomes defunct, include the
last_errorin theConnectionShutdownexception message.Before:
After:
This helps investigate #614 by preserving the original error reason when subsequent operations try to use a closed connection.
Test plan
send_msg()andwait_for_responses()verifyinglast_erroris included