Skip to content

Fix test_client_routes_change_event #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sylwiaszunejko wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix test_client_routes_change_event #656

sylwiaszunejko wants to merge 2 commits into from
+6 −12

Conversation

@sylwiaszunejko
Copy link
Collaborator

@sylwiaszunejko sylwiaszunejko commented Jan 28, 2026

Bumped SCYLLA_VERSION to verify that the test is working as expected.
Fixes: #652

@sylwiaszunejko
Copy link
Collaborator Author

sylwiaszunejko commented Jan 28, 2026

@Lorak-mmk There is some problem with this test, it uses xfail but with 2026.1 it is supposed to pass, but on the CI I saw error like this [XPASS(strict)] scylladb/scylladb#26992 - system.client_routes is not yet supported.
I thought I need to rebase on master to fix that, but I already see that in the currently running CI it also failed

mykaul
mykaul reviewed Jan 28, 2026
View reviewed changes
.github/workflows/integration-tests.yml
runs-on: ubuntu-24.04
env:
SCYLLA_VERSION: release:2025.2
SCYLLA_VERSION: release:2026.1
Copy link

@mykaul mykaul Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not released yet...

Copy link
Collaborator Author

@sylwiaszunejko sylwiaszunejko Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my mistake, I saw it on driver matrix and locally with this setting I was able to successfully run this test

Copy link
Collaborator Author

@sylwiaszunejko sylwiaszunejko Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the first version that supports CLIENT_ROUTES_CHANGE?

Copy link
Collaborator Author

@sylwiaszunejko sylwiaszunejko Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, it is 2026.1.0, so we need to use it at least for testing purposes in the PR, and remove the commit that bums the scylla version, before the merge, is that ok?

@sylwiaszunejko sylwiaszunejko self-assigned this Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkropachev dkropachev Awaiting requested review from dkropachev

@Lorak-mmk Lorak-mmk Awaiting requested review from Lorak-mmk

@mykaul mykaul Awaiting requested review from mykaul

At least 1 approving review is required to merge this pull request.

Assignees

@sylwiaszunejko sylwiaszunejko

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@sylwiaszunejko @mykaul @Lorak-mmk