4.x: Switch all Node API to use List instead of Set #785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
force-pushed
the
dk/switch-replica-stores-to-list
branch
2 times, most recently
from
9b65f50 to
d668fe1
Compare
nikagra
approved these changes
Jan 13, 2026
...main/java/com/datastax/oss/driver/internal/core/metadata/token/CanonicalNodeListBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastax/oss/driver/internal/core/metadata/DefaultTabletMap.java
Show resolved
Hide resolved
nikagra
requested changes
Jan 13, 2026
...main/java/com/datastax/oss/driver/internal/core/metadata/token/CanonicalNodeListBuilder.java
Outdated
Show resolved
Hide resolved
nikagra
requested changes
Jan 13, 2026
...main/java/com/datastax/oss/driver/internal/core/metadata/token/CanonicalNodeListBuilder.java
Outdated
Show resolved
Hide resolved
dkropachev
force-pushed
the
dk/switch-replica-stores-to-list
branch
3 times, most recently
from
7315d55 to
cc0cc85
Compare
Set - doesn't guarantee the order. When driver works with Nodes, say read replicas from TokenMap, Tablets, calculate replicas, API user should expect that order does matter and preserved. For that we need to switch all these APIs and internal structures to use Lists
dkropachev
force-pushed
the
dk/switch-replica-stores-to-list
branch
from
cc0cc85 to
3378431
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set - doesn't guarantee order of elements.
When driver works with Nodes, say read replicas from TokenMap, Tablets, calculate replicas, API user should expect that order does matter and preserved.
For that we need to switch all these APIs and internal structures to use Lists
Fix: #786