chore: update openssl and openssl-sys in Cargo.toml, update Cargo.lock#466
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR updates two OpenSSL-related dependencies in 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
| openssl-sys = "0.9.75" | ||
| openssl = "0.10.32" | ||
| openssl-sys = "0.9.114" | ||
| openssl = "0.10.78" |
There was a problem hiding this comment.
❓ Is there any reason to bump versions here?
Cargo.toml specifies minimal versions of dependencies, while Cargo.lock chooses the actual used versions. As you can see, we already used newer versions (openssl 0.10.75, openssl-sys 0.9.111) than Cargo.toml specified (openssl 0.10.32, openssl-sys 0.9.75)
There was a problem hiding this comment.
From our research, minimal version of openssl is openssl-v0.10.78 and for openssl-sys it's openssl-sys-v0.9.114 in order to support OpenSSL 4.
So the minimal version in this Cargo.toml should reflect that.
There was a problem hiding this comment.
I'm not opposed. I was just curious why update the Cargo.toml for that, when Cargo.lock update would achieve the same.
There was a problem hiding this comment.
Cargo.toml should, in general, specify the lowest viable dependency versions for the application to work correctly; Cargo.lock should specify the actual used versions.
Now, there may be users that want to use an older openssl crate in their driver build. For that, they'll specify a lower dep version in the Cargo.lock; they know they can safely do that as long as Cargo.toml allows for that.
There was a problem hiding this comment.
I was wondering about the failing checks on the PR build.
You're suggesting to only update the lock file with this merge request and leave the toml as the update is not necessary in general, depending on the OpenSSL version that consumers use?
I can update the PR.
There was a problem hiding this comment.
I was wondering about the failing checks on the PR build.
They are unrelated to this PR, I'm working on fixing them.
You're suggesting to only update the lock file with this merge request and leave the toml as the update is not necessary in general, depending on the OpenSSL version that consumers use? I can update the PR.
Indeed. Please update it.
The updated openssl and openssl-sys crates are necessary to support OpenSSL 4.
9674b94 to
03049bb
Compare
We want to update our OpenSSL to v4 (new API, no deprecations) and this requires newer versions for the rust openssl and openssl-sys crates.
Fixes: Cannot build driver with OpenSSL 4 (new API, no deprecations)
Makefilein{SCYLLA,CASSANDRA}_(NO_VALGRIND_)TEST_FILTER.Fixes:annotations to PR description.