Skip to content

bump Rust Driver to 1.6.0 + later panic fix#462

Open
wprzytula wants to merge 1 commit into
scylladb:masterfrom
wprzytula:bump-rust-driver-1.6.0-with-panic-fix
Open

bump Rust Driver to 1.6.0 + later panic fix#462
wprzytula wants to merge 1 commit into
scylladb:masterfrom
wprzytula:bump-rust-driver-1.6.0-with-panic-fix

Conversation

@wprzytula
Copy link
Copy Markdown
Contributor

@wprzytula wprzytula commented May 26, 2026

CI tests are failing due to a panic in the Rust Driver, which was fixed in scylla-rust-driver/pull/1644, after 1.6.0 was released. This PR updates the driver to commit
e04a12a9950cb3d051288541d5439835098c5cc2 (the newest commit on Rust Driver's main branch), which should fix the CI tests.

Cargo.lock's changes were performed by running:

cargo update -p scylla-cql -p scylla-proxy -p scylla --manifest-path=scylla-rust-wrapper/Cargo.toml

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • PR description sums up the changes and reasons why they should be introduced.
  • [ ] I have implemented Rust unit tests for the features/changes introduced.
  • [ ] I have enabled appropriate tests in Makefile in {SCYLLA,CASSANDRA}_(NO_VALGRIND_)TEST_FILTER.
  • [ ] I added appropriate Fixes: annotations to PR description.

Summary by CodeRabbit

  • Chores
    • Updated Scylla-related dependencies to a newer upstream revision for both runtime and development builds.
    • No public API or exported entities changed; observable behavior should remain the same.
    • Keeps the project aligned with upstream fixes and improvements.

Review Change Stack

@wprzytula wprzytula requested a review from Copilot May 26, 2026 09:01
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8723ef91-f1ce-49ee-a816-b800e718ecd3

📥 Commits

Reviewing files that changed from the base of the PR and between ae92850 and 938bf62.

⛔ Files ignored due to path filters (1)
  • scylla-rust-wrapper/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • scylla-rust-wrapper/Cargo.toml
✅ Files skipped from review due to trivial changes (1)
  • scylla-rust-wrapper/Cargo.toml

📝 Walkthrough

Walkthrough

This PR updates three Scylla crate dependencies to a specific git commit revision. The scylla production dependency and the scylla-proxy and scylla-cql development dependencies are all pinned to commit e04a12a9950cb3d051288541d5439835098c5cc2 replacing prior v1.5.0 tag references.

Changes

Dependency Revision Updates

Layer / File(s) Summary
Scylla crate revisions update
scylla-rust-wrapper/Cargo.toml
Scylla, scylla-proxy, and scylla-cql dependencies are updated to the same git revision e04a12a9950cb3d051288541d5439835098c5cc2, replacing the v1.5.0 tag references.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I hopped through Cargo.toml tonight,
Three crates nudged to one commit bright,
Tags to hashes, tidy and neat,
Locked in sync with a little beat,
A rabbit's stamp: dependencies right. 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: updating the Rust driver to version 1.6.0 and including a subsequent panic fix.
Description check ✅ Passed The PR description is complete and well-documented. It explains the motivation (fixing CI tests due to a panic), the specific commit being updated to, and the command used to update dependencies. The author properly marked non-applicable checklist items as skipped.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@wprzytula wprzytula requested a review from Lorak-mmk May 26, 2026 09:01
@wprzytula wprzytula self-assigned this May 26, 2026
@wprzytula wprzytula added this to the 1.1.0 milestone May 26, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the scylla-rust-wrapper crate to use a newer upstream scylla-rust-driver commit (post-1.6.0) intended to fix a CI-failing panic, and refreshes the lockfile accordingly.

Changes:

  • Pin scylla, scylla-cql, and scylla-proxy git dependencies to commit e04a12a9950cb3d051288541d5439835098c5cc2.
  • Update Cargo.lock to reflect the new scylla* crate versions (1.6.0 / 0.0.6) and updated transitive dependencies.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
scylla-rust-wrapper/Cargo.toml Pins Scylla Rust driver-related git dependencies to the specified upstream commit to pick up the panic fix.
scylla-rust-wrapper/Cargo.lock Lockfile refresh to match the updated driver commit and its transitive dependency graph.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wprzytula wprzytula force-pushed the bump-rust-driver-1.6.0-with-panic-fix branch from 2a98d81 to ae92850 Compare May 26, 2026 11:44
@wprzytula
Copy link
Copy Markdown
Contributor Author

Rebased on master, with the fix #463.

CI tests are failing due to a panic in the Rust Driver, which was fixed
in scylla-rust-driver/pull/1644, after 1.6.0 was released.
This PR updates the driver to commit
e04a12a9950cb3d051288541d5439835098c5cc2 (the newest commit on Rust
Driver's main branch), which should fix the CI tests.

`Cargo.lock`'s changes were performed by running:
```
cargo update -p scylla-cql -p scylla-proxy -p scylla --manifest-path=scylla-rust-wrapper/Cargo.toml
```
@wprzytula wprzytula force-pushed the bump-rust-driver-1.6.0-with-panic-fix branch from ae92850 to 938bf62 Compare May 26, 2026 18:05
@wprzytula
Copy link
Copy Markdown
Contributor Author

Force pushed just to trigger the checks, which (no idea why) didn't fire before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants