bump Rust Driver to 1.6.0 + later panic fix#462
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR updates three Scylla crate dependencies to a specific git commit revision. The ChangesDependency Revision Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the scylla-rust-wrapper crate to use a newer upstream scylla-rust-driver commit (post-1.6.0) intended to fix a CI-failing panic, and refreshes the lockfile accordingly.
Changes:
- Pin
scylla,scylla-cql, andscylla-proxygit dependencies to commite04a12a9950cb3d051288541d5439835098c5cc2. - Update
Cargo.lockto reflect the newscylla*crate versions (1.6.0 / 0.0.6) and updated transitive dependencies.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
scylla-rust-wrapper/Cargo.toml |
Pins Scylla Rust driver-related git dependencies to the specified upstream commit to pick up the panic fix. |
scylla-rust-wrapper/Cargo.lock |
Lockfile refresh to match the updated driver commit and its transitive dependency graph. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2a98d81 to
ae92850
Compare
|
Rebased on master, with the fix #463. |
CI tests are failing due to a panic in the Rust Driver, which was fixed in scylla-rust-driver/pull/1644, after 1.6.0 was released. This PR updates the driver to commit e04a12a9950cb3d051288541d5439835098c5cc2 (the newest commit on Rust Driver's main branch), which should fix the CI tests. `Cargo.lock`'s changes were performed by running: ``` cargo update -p scylla-cql -p scylla-proxy -p scylla --manifest-path=scylla-rust-wrapper/Cargo.toml ```
ae92850 to
938bf62
Compare
|
Force pushed just to trigger the checks, which (no idea why) didn't fire before. |
CI tests are failing due to a panic in the Rust Driver, which was fixed in scylla-rust-driver/pull/1644, after 1.6.0 was released. This PR updates the driver to commit
e04a12a9950cb3d051288541d5439835098c5cc2 (the newest commit on Rust Driver's main branch), which should fix the CI tests.
Cargo.lock's changes were performed by running:Pre-review checklist
[ ] I have implemented Rust unit tests for the features/changes introduced.[ ] I have enabled appropriate tests inMakefilein{SCYLLA,CASSANDRA}_(NO_VALGRIND_)TEST_FILTER.[ ] I added appropriateFixes:annotations to PR description.Summary by CodeRabbit