Skip to content

Raise clear error for all-empty shapes #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtreis merged 1 commit into from
May 20, 2026
Merged

Raise clear error for all-empty shapes #674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/spatialdata_plot/pl/basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1513,6 +1513,18 @@ def _draw_colorbar(
if fig_params.frameon is False:
ax.axis("off")

if has_shapes and wants_shapes:
empty_shape_elements = [
name
for name in wanted_elements
if name in sdata.shapes and not sdata.shapes[name]["geometry"].apply(lambda g: not g.is_empty).any()
]
if empty_shape_elements:
raise ValueError(
f"Cannot render shape element(s) {empty_shape_elements} in coordinate system {cs!r}: "
"all geometries are empty. Drop the element or restore at least one non-empty geometry."
)

extent = get_extent(
sdata,
coordinate_system=cs,
Expand Down
Loading