Reject NaN pixels in render_images#673
Merged
Merged
Conversation
Single-channel silently substituted na_color via cmap.set_bad; multi-channel silently composited NaN as black via additive per-channel cmaps without set_bad. Both paths now raise ValueError listing the offending channels and pointing to fillna().
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #673 +/- ##
==========================================
+ Coverage 77.63% 77.66% +0.03%
==========================================
Files 11 11
Lines 3612 3626 +14
Branches 850 856 +6
==========================================
+ Hits 2804 2816 +12
Misses 485 485
- Partials 323 325 +2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
render_imagespreviously had asymmetric, silent NaN handling: single-channel substitutedna_colorviacmap.set_bad, multi-channel additively composited NaN as opaque black through per-channel cmaps that did not carryset_bad. Both paths hid upstream data issues (stitched gaps, padded crops, masked tissue, segmentation outputs).ValueErrorearly in_render_imageswith the element name, offending channel(s), and afillna(...)hint.np.issubdtype(layer.dtype, np.floating)before materializing, souint8/uint16microscopy images pay no cost.Closes #628