feat: reset#31
Draft
flying-sheep wants to merge 2 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
==========================================
+ Coverage 97.90% 98.00% +0.09%
==========================================
Files 5 5
Lines 287 300 +13
==========================================
+ Hits 281 294 +13
Misses 6 6
🚀 New features to boost your workflow:
|
flying-sheep
commented
May 12, 2026
| # since we want to allow using this method imperatively, | ||
| # eagerly do the reset here instead of returning a context manager with a lazy `__enter__`. | ||
| for arg in prev_values: | ||
| default = type(self).model_fields[arg].get_default() |
Member
Author
There was a problem hiding this comment.
get_default optionally takes validated_data – are we supposed to just pass type(self).model_dump(self) here?
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.