feat: use blockscout chart #199
Conversation
sbaizet-ledger
force-pushed
the
feat-blockscout-chart
branch
from
20067c1 to
d939d77
Compare
sbaizet-ledger
force-pushed
the
feat-blockscout-chart
branch
from
d939d77 to
939d4aa
Compare
dghelm
left a comment
dghelm
left a comment
There was a problem hiding this comment.
So, we need to add blockscout-backend as an ingress value in config.toml so the CLI script will modify the production.yaml.
We may also want to wait to merge until we hear back on how to make things work without TLS for local devnet.
| # nginx.ingress.kubernetes.io/cors-allow-headers: "updated-gas-oracle, Content-Type, Authorization" | ||
| # nginx.ingress.kubernetes.io/cors-allow-methods: "GET, POST, OPTIONS" | ||
| # nginx.ingress.kubernetes.io/cors-max-age: "86400" | ||
| hostname: "blockscout-backend.hsk.scroll.systems" |
There was a problem hiding this comment.
I believe this should be blank, correct? And we'll want to add backend URL to the config.toml ingress section
There was a problem hiding this comment.
Made commit to add to scroll-sdk and examples folder config.tomls
| hostname: "blockscout-backend.hsk.scroll.systems" | ||
| tls: | ||
| enabled: true | ||
| secretName: blockscout-tls # Set here the hostname for the ingress. Example : blockscout-backend.scrollsdk |
There was a problem hiding this comment.
This comment isn't correct. Also, can we call this blockscout-backend-tls (otherwise the secrets use a different convention than the default URLs)
There was a problem hiding this comment.
Actually, I now see what you were doing here -- it needs a host section... do we want to specify TLS here when we haven't done that for any other services? Can we leave it mostly commented out for usage with devnet -- assuming disabling ECTO_USE_SSLand ETHEREUM_JSONRPC_HTTP_INSECURE fix localhost usage?
There was a problem hiding this comment.
i was starting to provide kind of a documentation inside the value file.
True that we haven't done that for the other services but we might consider this.
Not needed now though.
|
Also, after production.yaml is finalized, can you make a copy in |
|
should we also update l1-explorer to the latest version of blockscout? |
sbaizet-ledger
force-pushed
the
feat-blockscout-chart
branch
from
c69fbba to
d84cd7c
Compare
|
Alerting to #209 which is ready to be merged, but don't want to add more conflicts if you're already resolving. |
No description provided.