feat(verifier): commit terminal mode on verifier instance#1322
Closed
kunxian-xia wants to merge 3 commits into
Closed
feat(verifier): commit terminal mode on verifier instance#1322kunxian-xia wants to merge 3 commits into
kunxian-xia wants to merge 3 commits into
Conversation
Add VerifierMode{FullRun,PrefixRun,DebugSegment} on ZKVMVerifier and
collapse the full-trace + single-shard APIs into one mode-dispatched
verify_proofs. Fixes the e2e callers that were deriving expect_halt
from the proof itself, which made the halt-consistency check
tautological. Mode is chosen at construction from out-of-band info.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…dbook technical-overview.md now states only the production-mode (FullRun) guarantee. CLAUDE.md keeps the three-mode summary for contributors and drops the stale pointer to the mdbook's long form. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Re-adds the check on the halting shard; bound to public_values.exit_code via the halt-ecall chip's a0 register instance. PrefixRun and DebugSegment, as dev-only modes, remain unaffected. Updates the contract in CLAUDE.md and docs/src/technical-overview.md accordingly. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Collaborator
Author
|
Per discussion offline, we think this change is not necessary any more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1321.
Moves the full-trace / prefix-run / single-shard-debug distinction from a per-call
expect_haltflag onto the verifier instance as aVerifierModefield. Fixes the e2e callers that were derivingexpect_haltfrom the proof itself, which made the halt-consistency check tautological.VerifierMode { FullRun, PrefixRun, DebugSegment };ZKVMVerifier::new(vk)defaults toFullRun.verify_full_trace_proofs_halt+verify_single_shard_segment_haltcollapsed into one mode-dispatchedverify_proofs.exit_code,target_shard_id), never from the proof.CLAUDE.md+docs/src/technical-overview.mdrewritten around the three modes.