feat(3486): validate that requires only reference existing stages#185
Open
yk634 wants to merge 3 commits into
Open
feat(3486): validate that requires only reference existing stages#185yk634 wants to merge 3 commits into
yk634 wants to merge 3 commits into
Conversation
kumada626
approved these changes
May 19, 2026
y-oksaku
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
We found that a pipeline can currently accept a workflow where
requiresreferences a stage that does not exist in the YAML. When the UI tries to render a pipeline with that invalid workflow, it can crash.This PR was motivated by that failure mode: invalid stage references should be rejected during config parsing instead of being allowed through to later parts of the system.
Example of invalid YAML that motivated this change:
This configurations refer to stages that are not defined in stages, but they were not previously rejected by config validation.
Objective
This PR adds validation in config-parser so that requires can only reference stages that actually exist in the pipeline definition.
The change covers both of these cases:
requiresrequiresIt also extracts
normalizeRequiresinto a small shared helper sorequiresnormalization is handled consistently across the stage validation and flattening paths.References
screwdriver-cd/screwdriver#3486
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.