Skip to content

[UEPR-594] Focus outline #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adzhindzhi merged 3 commits into from
May 22, 2026
Merged

[UEPR-594] Focus outline #580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b870c4
fix: fixed global outline color and tab outline
kbangelov May 15, 2026
3f3a949
chore: remove comment
kbangelov May 15, 2026
489403b
fix: use rems and make outline similar in style to other outlines
adzhindzhi May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/scratch-gui/src/components/extension-button/extension-button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ $fade-out-distance: 15px;
}

.extension-button:focus-visible {
outline: revert;
outline: 0.0625rem auto $ui-black;
}

.extension-button-icon {
Expand Down
14 changes: 11 additions & 3 deletions packages/scratch-gui/src/components/gui/gui.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@
box-sizing: border-box;
}

:global(*:focus-visible) {
outline-color: $ui-black;
}

.flex-wrapper {
display: flex;

Expand Down Expand Up @@ -159,7 +163,7 @@
}

/* Tab style overrides from react-tabs */
.tab.is-selected:after {
.tab:after {
display: none;
}

Expand All @@ -169,8 +173,12 @@
border-color: $ui-black-transparent;
}

.tab.is-selected:focus:after {
display: none;
/* Focus outline for tabs */
.tab:focus-visible,
.tab.is-selected:focus-visible {
outline: 0.0625rem auto $ui-black;
outline-offset: -0.125rem; /* Looks better, otherwise it gets cut off by the canvas below */
z-index: 5; /* Display above tabs */
}

/* Body of the tabs */
Expand Down
2 changes: 2 additions & 0 deletions packages/scratch-gui/src/css/colors.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ $ui-transparent: hsla(0, 100%, 100%, 0); /* 25% transparent version of ui-white
$ui-black-transparent: hsla(0, 0%, 0%, 0.15); /* 15% transparent version of black */
$ui-black-transparent-10: hsla(0, 0%, 0%, 0.10); /* 10% transparent version of black */

$ui-black: hsla(0, 0%, 0%, 1); /* #000000 */

$ui-green: hsla(163, 85%, 35%, 1); /* #0DA57A */
$ui-green-2: hsla(163, 85%, 40%, 1); /* #0FBD8C */

Expand Down
Loading