[UEPR-477] Focus video on tutorial library choice with keyboard#579
Open
adzhindzhi wants to merge 7 commits into
Conversation
…com:scratchfoundation/scratch-editor into task/uepr-477-tips-library-return-focus-inconsistency-fix
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves keyboard accessibility for tutorial videos by focusing the Wistia player once it has fully loaded (accounting for Wistia’s asynchronous embed/API load), and removes the prior card-container focus approach.
Changes:
- Register a Wistia
_wqonReadycallback inVideoStepto focus the player when ready. - Clear focus-related wiring on the cards overlay (remove
tabIndex,ref, and theuseEffect-based focusing). - Update Jest snapshots to reflect the DOM attribute changes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/scratch-gui/src/components/cards/cards.jsx | Adds Wistia _wq onReady focus behavior; removes previous Cards-level focus logic and related attributes. |
| packages/scratch-gui/test/unit/components/snapshots/cards.test.jsx.snap | Updates snapshots for removal of tabindex="-1" on the overlay container. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Proposed Changes
Utilize the Wistia queue and JS API onReady function to focus the video when ready
Reason for Changes
Wistia API loads asynchronously making the video not present in the DOM on initial load when we try to focus it. This causes inconsistencies accessibility-wise, because users are unable to play the video the first time it loads.