tests: benchmarks, xdist#247
Conversation
b5fa1b2 to
6e44d36
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #247 +/- ##
=======================================
Coverage 97.97% 97.97%
=======================================
Files 9 9
Lines 493 493
Branches 84 84
=======================================
Hits 483 483
Misses 6 6
Partials 4 4 🚀 New features to boost your workflow:
|
d8f400b to
abd935f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
note to reviewers: the |
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
|
I did notice the upstream docs mention the need for That said, I suspect the main reason https://codspeed.io/scrapy/w3lib/branches/albertedwardson%3Apytest-benchmark does not show much is because until the benchmarks run on the main branch there is no baseline to compare with. |
|
maybe it doesn't like being run through |
|
yeah, |
|
ok, pypy is not supported: CodSpeedHQ/pytest-codspeed#34 |
|
I thought everything was working locally because I didn't notice the This means it doesn't even attempt to run the instrumentation, but only checks whether the tests pass |
|
idk how to do this nicely without excessive copypaste from real test cases |
This pull request introduces: