Conversation
|
regarding adding |
|
HI @lopuhin, I am actually still developing and testing so I have not deleted it but will do that but in the end, I will clean codes and remove them. |
|
Hey @gavishpoddar good job! 💪 I left some comments. We will iterate over this code and probably the result will be quite different, but really good to see that you are getting results so quickly 🚀 Let me know if there's something you need any clarification on. 😄 |
…into pr/gavishpoddar/932
Co-authored-by: Marc Hernández <noviluni@gmail.com>
noviluni
left a comment
There was a problem hiding this comment.
Awesome job! ✔️ 🚀
Really happy to see this happening 🎉 😄
lopuhin
left a comment
There was a problem hiding this comment.
Thanks for the great PR @gavishpoddar , added some minor notes, I think it's basically ready to be merged.
lopuhin
left a comment
There was a problem hiding this comment.
Looks great, thanks @gavishpoddar 👍
|
@gavishpoddar congrats on the merge, great work 👍 @noviluni sorry that I didn't ask before merging, I hope a merge commit is fine, or would you prefer a squash and merge? |
|
Thanks for the merge :) |
|
Hi @lopuhin, sorry for the late answer. I prefer to squash because in that way it is easier for me to build the changelog when releasing a new version, but no problem, it is fine :) (Congrats Gavish! 💪 ) |
Implementing optional language detection and allow the creation of custom language detection libraries by users.
This work is currently in progress and this PR is created for the monitoring purpose by the maintainers to suggest progress.
This PR is currently not complete.
TODOS:
fasttextmodel download.setup.pyfor optional language detection.parse,search_datesandDateDataParser.apply_settingindependent functions.dateparser-downloadset default caching folder.dateparser-download.detect_languages_func->detect_languages_function