Add Korean alternative date expressions#1289
Open
seungwoo-ji-03 wants to merge 2 commits intoscrapinghub:masterfrom
Open
Add Korean alternative date expressions#1289seungwoo-ji-03 wants to merge 2 commits intoscrapinghub:masterfrom
seungwoo-ji-03 wants to merge 2 commits intoscrapinghub:masterfrom
Conversation
Member
|
I see no YAML file edited, which makes me think you might have not seen https://dateparser.readthedocs.io/en/latest/contributing.html#guidelines-for-editing-translation-data. |
2a72767 to
9175252
Compare
Author
My bad, I updated files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for formal and colloquial Korean date expressions to improve parsing coverage.
Formal expressions (격식체):
금일- formal variant of오늘(today)작일- formal variant of어제(yesterday)명일- formal variant of내일(tomorrow)Colloquial expressions (구어체):
달- colloquial alternative to개월(month)3달 전(3 months ago),2달 후(in 2 months)